Skip to content

docs: document ALLOWED_HTTP_HOSTS env var#4

Merged
jeremyeder merged 1 commit intomainfrom
docs/allowed-http-hosts
Mar 20, 2026
Merged

docs: document ALLOWED_HTTP_HOSTS env var#4
jeremyeder merged 1 commit intomainfrom
docs/allowed-http-hosts

Conversation

@jeremyeder
Copy link
Copy Markdown
Contributor

Summary

  • Add ALLOWED_HTTP_HOSTS to the Environment variables table in DEPLOYMENT.md
  • Update Security Notes to document the env var approach (replaces old "edit mcp_server.py" guidance)
  • Note that deploy.sh auto-injects the OpenShift route hostname

Test plan

  • Doc reads correctly, no stale references

🤖 Generated with Claude Code

Add to Environment table and update Security Notes to reflect the env
var approach (replacing the old "edit mcp_server.py" guidance). Note
that deploy.sh auto-injects the route hostname for OpenShift overlays.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jeremyeder jeremyeder merged commit 5a204ff into main Mar 20, 2026
3 of 4 checks passed
@jeremyeder jeremyeder deleted the docs/allowed-http-hosts branch March 20, 2026 19:56
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 20, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 214e2e64-f9c1-4fb4-9be0-610df857c0a9

📥 Commits

Reviewing files that changed from the base of the PR and between 78c396f and 2b2b25c.

📒 Files selected for processing (1)
  • docs/DEPLOYMENT.md

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

Documentation update to docs/DEPLOYMENT.md clarifying ALLOWED_HTTP_HOSTS as a comma-separated environment variable for DNS rebinding protection, noting automatic configuration by deploy.sh for OpenShift deployments, and removing outdated guidance.

Changes

Cohort / File(s) Summary
Documentation
docs/DEPLOYMENT.md
Documents ALLOWED_HTTP_HOSTS as comma-separated environment variable with auto-configuration details for OpenShift deployments. Adds security configuration examples (OpenShift routes, reverse proxy hosts) and removes prior guidance on manual service hostname configuration in code.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/allowed-http-hosts

Comment @coderabbitai help to get the list of available commands and usage tips.

jeremyeder added a commit that referenced this pull request Mar 23, 2026
Add to Environment table and update Security Notes to reflect the env
var approach (replacing the old "edit mcp_server.py" guidance). Note
that deploy.sh auto-injects the route hostname for OpenShift overlays.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant